[electron] Add ability to create folder in OpenDialog on MacOS #7208
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegecko
added
filesystem
thegecko
changed the title
packages/filesystem/src/electron-browser/file-dialog/electron-file-dialog-service.ts
Outdated
Show resolved
Hide resolved
vince-fugnitto
added
OS/Mac
Older versions of MacOS don't have this icon (see my screenshot), so the new button was badly needed :)
I disagree, this type is already brought in with the Electron dependency and partially copied here, here and here. Perhaps I should reword the comment so it doesn't say "copied"? @marcdumais-work what do you think? |
+1 ; this case IMHO we're not literally copying code - we're just using an Electron API as per their documentation. |
Signed-off-by: Rob Moran <rob.moran@arm.com>
thegecko
force-pushed
the
electron-dialog-defaults
branch
from
e397237 to
3cecef9
Compare
|
Comment updated :) |
vince-fugnitto
removed
the
CQ Required (deprecated)
vince-fugnitto
approved these changes
Feb 25, 2020
|
Thanks @vince-fugnitto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rob Moran rob.moran@arm.com
What it does
With reference to the electron docs for the version we use (4.2.12), the file dialog on MacOS doesn't show the 'New Folder' button unless
properties.createDirectoryhas been set.This is restrictive behaviour when a user needs to use the file dialog to select a folder (
properties.openDirectoryset to true).Short of implementing this feature for all other platforms (Windows, Linux, Browser), an easier approach is to set the
createDirectoryproperty wheneveropenDirectoryis set on MacOS only.How to test
Ensure the
New Folderbutton appears when using the openDialog for folders in Electron for MacOS (e.g. open a new workspace).Review checklist
Reminder for reviewers